-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: Generic Implement #291
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #291 +/- ##
==========================================
Coverage ? 66.56%
==========================================
Files ? 113
Lines ? 7230
Branches ? 0
==========================================
Hits ? 4813
Misses ? 1946
Partials ? 471
Continue to review full report at Codecov.
|
@AlexStocks Do you think I should capitalize the first letter of methodName for generic invoke because the first letter of go's methodName should be upper. |
pls give some adives @fangyincheng @hxmhlt @pantianying |
you need a switch to control whether |
@fangyincheng In java sdk, generic filter is default filter. In go, do we need to control it be working? |
dubbo-go support lowercase method to provide a service. |
ok |
I see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Has it been tested with java Dubbo? |
@fangyincheng yeah, I tested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4854646
to
527f21e
Compare
What this PR does:
Ftr: add Generic Implement
Which issue(s) this PR fixes
Fixes #290
Special notes for your reviewer:
Does this PR introduce a user-facing change?: